Implement ISOSDacInterface::GetObjectClassName in cDAC SOSDacImpl#124816
Open
Implement ISOSDacInterface::GetObjectClassName in cDAC SOSDacImpl#124816
Conversation
Contributor
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
…unit and dump tests Co-authored-by: max-charlamb <44248479+max-charlamb@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Implement ISOSDacInterface::GetObjectClassName in SOSDacImpl.cs
Implement ISOSDacInterface::GetObjectClassName in cDAC SOSDacImpl
Feb 24, 2026
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/SOSDacImpl.cs
Show resolved
Hide resolved
Member
max-charlamb
left a comment
max-charlamb
left a comment
There was a problem hiding this comment.
@copilot , address feedback
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/SOSDacImpl.cs
Outdated
Show resolved
Hide resolved
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/SOSDacImpl.cs
Outdated
Show resolved
Hide resolved
… case, update tests Co-authored-by: max-charlamb <44248479+max-charlamb@users.noreply.github.com>
Contributor
Author
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/SOSDacImpl.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: max-charlamb <44248479+max-charlamb@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Implements the cDAC version of ISOSDacInterface::GetObjectClassName in SOSDacImpl, replacing the legacy-only stub, and adds unit + dump-based tests to validate method-table → type/module resolution and string output behavior.
Changes:
- Add cDAC implementation of
GetObjectClassNameusingIObject,IRuntimeTypeSystem,ILoader, andTypeNameBuilderwith a fallback toDacStreams. - Add unit tests covering zero address, unloaded-type naming, and “null buffer returns needed size” behavior.
- Add dump-based integration tests validating that
System.ObjectandSystem.Stringresolve to modules with loaded image contents.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/SOSDacImpl.cs | Implements GetObjectClassName in cDAC, including unloaded-module handling, TypeNameBuilder formatting, and DEBUG cross-check vs legacy DAC. |
| src/native/managed/cdac/tests/ObjectTests.cs | Adds unit tests for GetObjectClassName argument handling and unloaded-type naming behavior. |
| src/native/managed/cdac/tests/DumpTests/RuntimeTypeSystemDumpTests.cs | Adds dump tests ensuring Object/String MTs map to modules with loaded image contents via Loader contract. |
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/SOSDacImpl.cs
Show resolved
Hide resolved
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/SOSDacImpl.cs
Show resolved
Hide resolved
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@objectback toobjectContractvariable namecDAC_windows_x64_releaseSOS.UnitTests failure is pre-existing onmain(all 5 recent builds fail identically)runtimepipeline succeeded; 880 cDAC unit tests pass locally✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.